Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: json schema draft 7 to openapi schema converting #797

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

ivan-tymoshenko
Copy link
Member

This PR combines all common transformations from the json schema draft 7 to openapi component schema into one function + adds comments for trouble spots. I will try to refactor the plugin with small steps like that one.

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit e01cd7b into master Apr 19, 2024
21 checks passed
@gurgunday gurgunday deleted the refactor-schema-converting branch April 19, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants