-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop websocket-stream and just use ws #32
Comments
I have started some coding to check it. Do you know why in the test has been used |
no clue. Link?
Il giorno ven 23 ago 2019 alle 22:23 Manuel Spigolon <
notifications@github.com> ha scritto:
… I have started some coding to check it.
Do you know why in the test has been used connection.socket?
It is a matter only of streaming-apis and eventemitter-apis?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32?email_source=notifications&email_token=AAAMXY5R2KJTZDEX5ELGKUDQGBBMNA5CNFSM4IM5YQI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5BHR7Y#issuecomment-524450047>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAMXY2HCGQAXAUNOVTLKYTQGBBMNANCNFSM4IM5YQIQ>
.
|
This is one example: fastify-websocket/test/router.js Lines 119 to 123 in 68f2b4c
|
Did that on(‘message’) block run right now? I does not seem so. Also, The
client is connecting to a different URL.
Il giorno sab 24 ago 2019 alle 09:25 Manuel Spigolon <
notifications@github.com> ha scritto:
… This is one example:
https://github.com/fastify/fastify-websocket/blob/68f2b4c9d1979b97e6eb5017b83dc9bd3150cba4/test/router.js#L119-L123
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32?email_source=notifications&email_token=AAAMXY54GSRK7INEQIQCTIDQGDO7FA5CNFSM4IM5YQI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5B2VGY#issuecomment-524528283>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAMXY4K7UYT5TD2A4SSBGLQGDO7FANCNFSM4IM5YQIQ>
.
|
Hi. That test is correct since it test |
What is the difference with https://github.com/gj/fastify-ws ? |
This library has many more features. |
Closing since this issue has been completed in #38 |
The ws added support for native node streams. We can drop websocket-stream and just use that.
https://www.npmjs.com/package/ws#use-the-nodejs-streams-api
The text was updated successfully, but these errors were encountered: