Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for trust proxy with function #1098

Merged
merged 1 commit into from
Aug 26, 2018
Merged

Add test for trust proxy with function #1098

merged 1 commit into from
Aug 26, 2018

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 26, 2018

Confirmed that following branch is covered in coverage results:

fastify/fastify.js

Lines 220 to 222 in 6bce249

if (typeof tp === 'function') {
return tp
}

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • commit message and code follows Code of conduct

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit e77cae9 into fastify:master Aug 26, 2018
@trivikr trivikr deleted the trust-proxy-func-test branch August 26, 2018 09:23
@delvedor delvedor added the internals Change that won't impact the surface API. label Aug 26, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
internals Change that won't impact the surface API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants