Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Logging.md #1292

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Update Logging.md #1292

merged 2 commits into from
Dec 4, 2018

Conversation

fralonra
Copy link
Member

@fralonra fralonra commented Dec 2, 2018

  1. revised L28
  2. removed duplicated code (L55)

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@fralonra
Update Logging.md
9cb2eee 
1. revised L28
2. removed duplicated code (L55)
cemremengu
cemremengu reviewed Dec 2, 2018
View reviewed changes
Copy link
Contributor

@cemremengu cemremengu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "duplicate" code helps to show that nothing changes in a route definition by giving a complete example

mcollina
mcollina approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this is ok.

nileshmali
nileshmali reviewed Dec 4, 2018
View reviewed changes
docs/Logging.md Outdated Show resolved Hide resolved
@nileshmali @fralonra
Update docs/Logging.md
9c3563e 
fix typo: desintation -> destination

Co-Authored-By: fralonra <zoronlivingston@gmail.com>
mcollina
mcollina approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cemremengu
cemremengu approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@cemremengu cemremengu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

delvedor
delvedor approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor added the documentation Improvements or additions to documentation label Dec 4, 2018
@delvedor delvedor merged commit 75f043b into fastify:master Dec 4, 2018
@fralonra fralonra deleted the patch-3 branch December 4, 2018 15:21
@fralonra fralonra mentioned this pull request Dec 6, 2018
Open
21 tasks
@cemremengu cemremengu mentioned this pull request Dec 6, 2018
Closed
@poppinlp poppinlp mentioned this pull request Dec 16, 2018
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nileshmali nileshmali nileshmali left review comments

@delvedor delvedor delvedor approved these changes

@cemremengu cemremengu cemremengu approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fralonra @mcollina @cemremengu @nileshmali @delvedor