-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Benchmarks are seperated #183
Conversation
I've invited you to the orgazination, would you mind to move the repo over? Thanks! |
I carried the repository. Thank you for your kindly invitation, I would like to help you with other issues. |
package.json
Outdated
@@ -40,32 +40,25 @@ | |||
"node": ">=4.5" | |||
}, | |||
"devDependencies": { | |||
"autocannon": "^0.16.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thank you for contributing :)
Can you restore this dependency?
It is needed by our benchmark script :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove that script. Fastify has benchmarks in separated repository now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, we are using it to test master
against the some-feature
branch to see if there are performances regression ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
All the links will need to be updated at http://www.fastify.io/benchmarks/ |
…/fastify-cli-2.9.0 Bump fastify-cli from 2.8.0 to 2.9.0
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
#180 issue fixes.
benchmarks