Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Benchmarks are seperated #183

Merged
merged 2 commits into from
Sep 12, 2017
Merged

✨ Benchmarks are seperated #183

merged 2 commits into from
Sep 12, 2017

Conversation

cagataycali
Copy link
Contributor

#180 issue fixes.

benchmarks

@mcollina
Copy link
Member

mcollina commented Sep 9, 2017

I've invited you to the orgazination, would you mind to move the repo over? Thanks!

@cagataycali
Copy link
Contributor Author

I carried the repository. Thank you for your kindly invitation, I would like to help you with other issues.

package.json Outdated
@@ -40,32 +40,25 @@
"node": ">=4.5"
},
"devDependencies": {
"autocannon": "^0.16.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for contributing :)

Can you restore this dependency?
It is needed by our benchmark script :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove that script. Fastify has benchmarks in separated repository now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, we are using it to test master against the some-feature branch to see if there are performances regression ;)

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dougwilson
Copy link

All the links will need to be updated at http://www.fastify.io/benchmarks/

@mcollina mcollina merged commit 1061b2b into fastify:master Sep 12, 2017
haggholm pushed a commit to haggholm/fastify that referenced this pull request Jun 12, 2021
…/fastify-cli-2.9.0

Bump fastify-cli from 2.8.0 to 2.9.0
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2022
@Eomm Eomm added the semver-minor Issue or PR that should land as semver minor label Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semver-minor Issue or PR that should land as semver minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants