Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: throw on root-level required #134

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Conversation

erfanium
Copy link
Contributor

@erfanium erfanium commented Jun 2, 2021

Fixes #132
I added isRoot option for valueOf method, which is true by default and false for internal calls.
I didn't update .d.ts files, should I do?

Checklist

src/BaseSchema.js Outdated Show resolved Hide resolved
src/types/index.js Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 900830188

  • 0 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 99.559%

Totals Coverage Status
Change from base Build 892669691: 0.005%
Covered Lines: 410
Relevant Lines: 410

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 3, 2021

Pull Request Test Coverage Report for Build 903541000

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 99.559%

Totals Coverage Status
Change from base Build 892669691: 0.005%
Covered Lines: 410
Relevant Lines: 410

💛 - Coveralls

src/BaseSchema.test.js Outdated Show resolved Hide resolved
@aboutlo
Copy link
Collaborator

aboutlo commented Jun 3, 2021

tks @erfanium! LGTM

@erfanium erfanium requested review from mcollina and aboutlo June 3, 2021 16:30
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aboutlo aboutlo merged commit 309de72 into fastify:master Jun 18, 2021
@erfanium erfanium deleted the fix-#132 branch June 18, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Root level required creates invalid schema
4 participants