Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add env_vars GH_AUTH_TOKEN to deploy step. #130

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

syedfarhanNF
Copy link

Description

  • Update github workflow for deployment to include env_vars GH_AUTH_TOKEN that reads the token from the repos secrets.
  • Update readme to add step for creating Github Personal Access Token

Notes

  • Personal access tokens can only be created for a specific user. There isn't a way to create org level personal access tokens to use with the GitHub api. The scope of this should be limited to read public repositories only.

Checklist

@syedfarhanNF
Copy link
Author

@mcollina Can you verify the secret token is set correctly in the repo settings - the name and that the token is still valid. And merge this PR if those are correct? I don't have visibility into those settings because I'm not a member of the fastify org.

@Eomm Eomm linked an issue May 12, 2023 that may be closed by this pull request
@simoneb
Copy link
Collaborator

simoneb commented Sep 18, 2023

We kind of forgot about this issue. I think this was intended to authenticate to the GH APIs and increase the rate limits, considering that this is now being used by both the Fastify and Mercurius websites. On the other hand, I'm not sure this is safe to merge, we would need somebody to check that the token in the secrets is right. Having a PAT there is a possible security risk, so unless the apps are causing troubles, which it doesn't seem at the moment (see here and here), we can also close this issue. What's certain though, is that if requests are made too frequently to those pages, they will stop working for some time due to hitting the rate limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to configure with a Github token
2 participants