Router not working with specific url.

[painor]

I have this router in my code

fastify.get('/:link', (req, reply) => {
    req.params.url = req.host+req.url;
    reply.view("template.ejs",req.params);

});

I am trying to catch URLs and handle them in the template. The URLs are all encodeURIComponent escaped. for some reason, some URLs would return a 404 not found and I am not sure why.
This is the link that worked.

http://127.0.0.1:3000/https%3A%2F%2Fupload.wikimedia.org%2Fwikipedia%2Fcommons%2Fe%2Fee%2FChain_link_icon.png

and this is the one that didn't work.

http://127.0.0.1:3000/https%3A%2F%2Fs7386.pcdn.co%2Fwp-content%2Fuploads%2F2016%2F07%2Fadd-on-direct-link-tracking-771x386.png

the error is

{
"message": "Route GET:/https%3A%2F%2Fs7386.pcdn.co%2Fwp-content%2Fuploads%2F2016%2F07%2Fadd-on-direct-link-tracking-771x386.png not found",
"error": "Not Found",
"statusCode": 404
}

using windows 10
node v12.8.0
fastify 2.8.0

[RafaelGSS]

You can try receive the link by query params and passing:

youdomain/link?url=https://example.com/img.jpg and use regexp inside schema to get only pictures.

[Eomm]

@RafaelGSS that is a nicer solution 👍

Anyway, the problem here is the length of the path parameter that is 100 char

Here the details: https://github.com/delvedor/find-my-way

You can set a custom length for parameters in parametric (standard, regex and multi) routes by using maxParamLength option, the default value is 100 characters.
If the maximum length limit is reached, the default route will be invoked.

[StarpTech]

@Eomm only 100 chars seems odd to me. We should change that default in fastify and a clean error should be logged.

[Eomm]

You can already set it up
https://github.com/fastify/fastify/blob/master/docs/Server.md#maxparamlength
I should have pointed it out to @painor

Maybe to throws an error we should check the routing lib

[painor]

Oh thanks. I tried debugging but it tricked me because when I removed the .png it worked so I thought maybe it was the extension and was debugging that for hours lol.

[StarpTech]

@Eomm nevermind this only effects the "path" 😄

[kireerik]

#103 (comment)

@StarpTech I highly agree. I recommend we open this issue and resolve it accordingly.