Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to the body and query #128

Merged
merged 7 commits into from
Jan 19, 2022
Merged

Conversation

dr3
Copy link
Contributor

@dr3 dr3 commented Jan 11, 2022

Allows access to query, and body when it is available (in preValidation hook onwards)

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests for both the types and the code?

@mcollina
Copy link
Member

Also docs

@dr3 dr3 marked this pull request as ready for review January 11, 2022 17:31
@dr3 dr3 requested a review from mcollina January 11, 2022 18:00
@dr3 dr3 requested a review from mcollina January 12, 2022 16:47
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would release it as major version

@mcollina mcollina merged commit e485e5d into fastify:master Jan 19, 2022
@anthonyp-usafacts
Copy link

@dr3 just saw these features -- Thanks for your addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants