Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Fastify 2.0 #96

Closed
Extarys opened this issue Jan 22, 2019 · 7 comments
Closed

Update for Fastify 2.0 #96

Extarys opened this issue Jan 22, 2019 · 7 comments
Labels
good first issue Good for newcomers

Comments

@Extarys
Copy link

Extarys commented Jan 22, 2019

Error: fastify-plugin - expected '^1.1.0' fastify version, '2.0.0' is installed

If/when someone have time,

😄 🐭 🧀

@mcollina mcollina added the good first issue Good for newcomers label Jan 23, 2019
@mcollina
Copy link
Member

Thanks, would you like to send a PR?

@cemremengu
Copy link
Contributor

@mcollina Should we update devDependency for this (and other >=1.x plugins as well) ?

@mcollina
Copy link
Member

what do you mean? I would just release a new major for this, or relax https://github.com/fastify/point-of-view/blob/master/index.js#L288.

@cemremengu
Copy link
Contributor

I meant whether it is alright to relax the constraint without bumping https://github.com/fastify/point-of-view/blob/master/package.json#L43

@mcollina
Copy link
Member

mcollina commented Jan 23, 2019 via email

@Extarys
Copy link
Author

Extarys commented Jan 24, 2019

Sorry @mcollina I would love to but I'm too busy right now. I opened the issue in case someone had more time than me and to make sure it would eventually be done.
Also I'm quite noob to fastify plugins I think it would require me a lot more time than someone who's actually familiar with the Fastify ecosystem.

@cemremengu
Copy link
Contributor

Landed in #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants