Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace mocha with tap #5

Closed
wants to merge 0 commits into from
Closed

Replace mocha with tap #5

wants to merge 0 commits into from

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jan 12, 2023

based on #3, so that should be merged first.

Checklist

Eomm
Eomm reviewed Jan 12, 2023
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know this repo - adding some topics

.taprc Outdated
files:
- test/**/*.test.js

check-coverage: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would set the minimum

Suggested change
check-coverage: false
check-coverage: 96

@Uzlopak Uzlopak closed this Jan 12, 2023
@Uzlopak Uzlopak mentioned this pull request Jan 12, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @Eomm