Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auto-merge-exclude workflow input #12

Merged
merged 6 commits into from
Feb 21, 2022
Merged

feat: add auto-merge-exclude workflow input #12

merged 6 commits into from
Feb 21, 2022

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Feb 21, 2022

Not 100% on if an empty string is acceptable as the default for excludes for fastify/github-action-merge-dependabot, which is what string inputs fall back to.

Tackles #11 (comment)

Checklist

@Fdawgs Fdawgs requested review from mcollina and Eomm February 21, 2022 13:05
@Fdawgs Fdawgs changed the title feat: add auto-merge-excludes workflow input feat: add auto-merge-exclude workflow input Feb 21, 2022
@mcollina
Copy link
Member

I would put fastify there by default, wdyt?

@Fdawgs
Copy link
Member Author

Fdawgs commented Feb 21, 2022

I would put fastify there by default, wdyt?

Good idea, that's the big dog, just let me fix this broken print server.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit aa5f3ac into main Feb 21, 2022
@Fdawgs Fdawgs deleted the feat/excludes branch February 21, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants