Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove node 18 and add node 22 #131

Merged
merged 1 commit into from
May 25, 2024
Merged

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday requested a review from Fdawgs May 25, 2024 12:21
@gurgunday gurgunday merged commit 8dccd9d into fastify:main May 25, 2024
1 check passed
@gurgunday gurgunday deleted the remove-18 branch May 25, 2024 16:47
@Eomm
Copy link
Member

Eomm commented Jun 9, 2024

Should we land this as major or we must wait or this GHA will be updated automatically by dependabot? If so we did not solve this automatic pain

@mcollina
Copy link
Member

mcollina commented Jun 9, 2024

This should be a major.

@gurgunday
Copy link
Member Author

If we release using the workflow, dependabot will start, but so far we’ve released manually so nothing is getting updated, it should be fine with another major too, just make sure not to release v5 but v5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants