Skip to content
This repository has been archived by the owner on Nov 19, 2018. It is now read-only.

scan is twice slower on building code #35

Closed
yakimant opened this issue Nov 6, 2015 · 10 comments
Closed

scan is twice slower on building code #35

yakimant opened this issue Nov 6, 2015 · 10 comments
Assignees
Labels

Comments

@yakimant
Copy link

yakimant commented Nov 6, 2015

As I see - the difference between my xcodebuild arguments and scan generated is:
I run clean test and scan runs clean build test.

I also see duplicates of compiling lines.

Is it building twice?

@tutipeti
Copy link

Any feedback here? I find it funny how fastlane is telling me that it saved me time when I can easily see that scan is compiling twice - so running the tests takes about twice as long as it did when I were using only xcodebuild.

@arunks
Copy link

arunks commented Dec 7, 2015

Looks like this is an issue. I tried running the xcodebuild command generated by scan directly without the build option. Just clean test. That seems to have cut the time in half.

@KrauseFx
Copy link
Collaborator

@yakimant did you test everything when removing the build part of the command? I'm pretty sure there was a reason this was added to scan a while back, but can't remember why.

@attheodo
Copy link

+1 for that. scan takes significantly more because it involves rebuilding the whole thing VS hitting CMD+U on Xcode. clean: false doesn't seem to help.

@arunks
Copy link

arunks commented Dec 19, 2015

@KrauseFx I have been using xcodebuild to workaround this problem, instead of Scan. Currently, I am just passing the test command and have seen no issues with it in running our CI.

Also, I compared the execution times of just xcodebuild test from fastlane and using Scan from fastlane. Scan is considerably slower because does a build and test. Hope this helps.

I have a PR, if you think everything's alright - #62

@kdawgwilk
Copy link

I am also seeing not only everything built twice but the tests are being ran twice 😁 Looks like I am going to switch back to xcodebuild till it gets fixed

@nikolaykasyanov
Copy link

same here.

@kdawgwilk
Copy link

Was able to speed things up thanks to #86 by using gym to build the binary first then run scan with the new skip_build flag and then deploying same binary that was used for the tests 😊 before this change scan would build the app and test and then gym would build again after tests succeeded

@KrauseFx
Copy link
Collaborator

Yeah, thanks for updating this issue, this is now implemented with #86

@fastlanebot
Copy link

This issue was migrated to fastlane/fastlane#3353. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo 🚀

@fastlane-old fastlane-old locked and limited conversation to collaborators Mar 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

8 participants