Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scan is twice slower on building code #3353

Closed
fastlanebot opened this issue Nov 6, 2015 · 11 comments
Closed

scan is twice slower on building code #3353

fastlanebot opened this issue Nov 6, 2015 · 11 comments

Comments

@fastlanebot
Copy link

Original issue by @yakimant - Imported from fastlane/scan#35

As I see - the difference between my xcodebuild arguments and scan generated is:
I run clean test and scan runs clean build test.

I also see duplicates of compiling lines.

Is it building twice?

@fastlanebot
Copy link
Author

@tutipeti commented

Any feedback here? I find it funny how fastlane is telling me that it saved me time when I can easily see that scan is compiling twice - so running the tests takes about twice as long as it did when I were using only xcodebuild.

@fastlanebot
Copy link
Author

@arunks commented

Looks like this is an issue. I tried running the xcodebuild command generated by scan directly without the build option. Just clean test. That seems to have cut the time in half.

@fastlanebot
Copy link
Author

@KrauseFx commented

@yakimant did you test everything when removing the build part of the command? I'm pretty sure there was a reason this was added to scan a while back, but can't remember why.

@fastlanebot
Copy link
Author

@attheodo commented

+1 for that. scan takes significantly more because it involves rebuilding the whole thing VS hitting CMD+U on Xcode. clean: false doesn't seem to help.

@fastlanebot
Copy link
Author

@arunks commented

@KrauseFx I have been using xcodebuild to workaround this problem, instead of Scan. Currently, I am just passing the test command and have seen no issues with it in running our CI.

Also, I compared the execution times of just xcodebuild test from fastlane and using Scan from fastlane. Scan is considerably slower because does a build and test. Hope this helps.

I have a PR, if you think everything's alright - fastlane-old/scan#62

@fastlanebot
Copy link
Author

@kdawgwilk commented

I am also seeing not only everything built twice but the tests are being ran twice 😁 Looks like I am going to switch back to xcodebuild till it gets fixed

@fastlanebot
Copy link
Author

@Corristo commented

same here.

@fastlanebot
Copy link
Author

@kdawgwilk commented

Was able to speed things up thanks to #86 by using gym to build the binary first then run scan with the new skip_build flag and then deploying same binary that was used for the tests 😊 before this change scan would build the app and test and then gym would build again after tests succeeded

@fastlanebot
Copy link
Author

@KrauseFx commented

Yeah, thanks for updating this issue, this is now implemented with fastlane-old/scan#86

@ivanbruel
Copy link
Contributor

@kdawgwilk any chance you can provide a concrete example on your work around?

My StackOverflow post provides a bit of context.

@TKBurner
Copy link

@ivanbruel Just set the --skip_build flag to true. Thanks!

@fastlane fastlane locked and limited conversation to collaborators Dec 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants