This repository has been archived by the owner on Nov 19, 2018. It is now read-only.
Added option to skip pretest build #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,7 +48,7 @@ def actions | |||
|
|
|||
| actions = [] | |||
| actions << :clean if config[:clean] | |||
| actions << :build | |||
| actions << :build if !config[:skip_pretest_build] | |||
There was a problem hiding this comment.
Favor unless over if for negative conditions.
|
Great idea, I added a comment before it's ready to be merged. Please also squash the commits and let me know when you updated the PR 👍 |
|
Hey thanks for the feedback, i have made the change to the key but for some reason travis is now failing the build but it seems to be an issue with travis from looking at the logs. |
|
Yah, seems like a Travis issue, don't worry about it |
KrauseFx
added a commit
that referenced
this pull request
Feb 5, 2016
Added option to skip pretest build
|
Looks great, thanks for updating the PR, this will be in the next release 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #62 we have found that this extra build step is not needed for us but i'm aware that many users may be relying on this for some build artifacts so i propose adding an option that would allow this to be skipped without changing the default behaviour.