Skip to content
This repository has been archived by the owner on Nov 19, 2018. It is now read-only.

Remove build from test_command_generator #62

Closed
wants to merge 2 commits into from

Conversation

arunks
Copy link

@arunks arunks commented Dec 19, 2015

This is to remove the build command from scan. The test command builds and tests the UTs, adding a build command to this makes it redundant and increases execution times.

@KrauseFx
Copy link
Collaborator

There was a reason why the build command was there, this will need some additional trying if everything works as expected.

@mfurtak mfurtak assigned ohayon and unassigned mfurtak Dec 20, 2015
@mfurtak
Copy link
Contributor

mfurtak commented Dec 20, 2015

I don't have a good setup to test this right now, so I wonder if @ohwutup can provide feedback more quickly?

@ohayon
Copy link
Contributor

ohayon commented Dec 21, 2015

hey @arunks! thanks for making this PR!

we have run some initial tests and are finding that while having the build step may appear redundant, that when xcodebuild is running the test command, it does not rebuild the scheme a second time, rather, it just builds the tests.

if you could, it would be great to see any logs that you may have that show the duplicated build that cause the lengthy run times of scan. either that, or if you have a test project that you could share we could do some deeper digging.

thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants