Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

Post comments on GitHub with the test failure information, ideally the stack trace + error message. That's a freeby, as we already set the build status #58

Closed
KrauseFx opened this issue Jan 28, 2018 · 1 comment
Closed

Post comments on GitHub with the test failure information, ideally the stack trace + error message. That's a freeby, as we already set the build status #58

KrauseFx opened this issue Jan 28, 2018 · 1 comment
Labels
complexity: you can do this
Milestone
GitHub API integr...

Comments

@KrauseFx
Copy link
Member

KrauseFx commented Jan 28, 2018 •
edited
Loading

We could start as simple as adding a comment to the PR with Build failed because of 'rspec 34 tests failed' or similar, and then we can slowly expand this to support more.

It kind of conflicts with danger, so let's think about what's the healthiest option of not duplicating danger features
@KrauseFx KrauseFx self-assigned this Jan 28, 2018
@taquitos taquitos mentioned this issue Jan 29, 2018
Closed
3 tasks
@taquitos taquitos added this to the GitHub API integration milestone Jan 30, 2018
@KrauseFx KrauseFx removed their assignment Feb 14, 2018
@KrauseFx
Copy link
Member Author

Actually let's remove this for now, shouldn't be part of v1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
complexity: you can do this
Projects
None yet
Milestone
GitHub API integration
Development

No branches or pull requests
2 participants
@KrauseFx @taquitos