Rip out more dead analytics code #13741
Conversation
The code was unused, and we have no plans on adding analytics again
|
Let's see if tests pass |
Generated by 🚫 Danger |
|
not big |
fastlane/lib/fastlane/fast_file.rb
Outdated
| # This value helps us track success/failure metrics for Fastfiles we | ||
| # generate as part of an automated process. | ||
| ENV['GENERATED_FASTFILE_ID'] = id | ||
| UI.important("The `generated_fastfile_id` action was deprected, you can remove the line from your Fastfile") |
|
big if true |
Co-Authored-By: KrauseFx <KrauseFx@gmail.com>
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
|
Hey @KrauseFx 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
…select * upstream/master: (34 commits) Use HTTPs for Facebook frame URL (fastlane#13771) [spaceship] improve client (mainly: login) (fastlane#13736) [spaceship] Fix environment variable provided sessions (fastlane#13743) Allow for the host of the Appetize API to be configured (fastlane#13765) Improves parse error reporting for non-conventional setups (fastlane#13769) Use `crash!` instead of `user_error!` on configuration access mis-use (fastlane#13766) Rip out more dead analytics code (fastlane#13741) [spaceship] support --verbose for `fastlane spaceauth` (fastlane#13752) [fastlane_core] Fix project_paths() in project.rb to respect `container:` references (fastlane#13662) [precheck] Allow mentioning Google Drive (fastlane#13754) [crashlytics] fix generated command (generate_android_command) for Windows (fastlane#13597) [docs] add id to plugin headline so it becomes linkable (fastlane#13727) [match] add new option to recreate deleted profiles in dev portal (fastlane#12539) Update puts.rb (fastlane#13739) Improve Spaceship API documentation (fastlane#13724) Update gym docs (fastlane#13725) Testfairy upload timeout (fastlane#13674) [resign.sh] only create the archived-expanded-entitlements.xcent file if the version of Xcode < 9.3 (fastlane#13685) [spaceship] remove application and version from app submission params (fastlane#13695) Improve AdbHelper (fastlane#13692) ... # Conflicts: # spaceship/lib/spaceship/two_step_or_factor_client.rb
The code was unused, and we have no plans on adding this kind of analytics again