[precheck] Allow mentioning Google Drive #13754
Conversation
The allowed case fails because Google is flagged.
Our app PDF Viewer has been approved while mentioning Google Drive in the App Store description. Other apps that use UIDocumentBrowserViewController may want to mention this too. The OtherPlatformsRule tests now pass.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
CLAs look good, thanks! |
|
Thanks for these changes! Semi OT: Is mentioning "Google" actually a problem? "Android" I get, but the company in general? |
|
I don’t know. I'm sceptical about whether most of these other platform checks are useful. Most of them seem irrelevant these days and unlikely to be used or be a problem. Android seems a good warning as that's definitely caused some people trouble in the past. Google seems a bad warning to me. We already have two examples, and there are lots more Google services an iOS might mention reasonably. Or the app might be one made by Google itself :) So if it might be accepted, I'd say +1 to just removing google from the blacklist. |
| describe Precheck::OtherPlatformsRule do | ||
| let(:rule) { OtherPlatformsRule.new } | ||
| let(:allowed_item) { TextItemToCheck.new("We have integration with the Files app so you can open documents stored in your Google Drive.", :description, "description") } | ||
| let(:forbidden_item) { TextItemToCheck.new("Google is really great.", :description, "description") } |
|
Hey @douglashill 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
…select * upstream/master: (34 commits) Use HTTPs for Facebook frame URL (fastlane#13771) [spaceship] improve client (mainly: login) (fastlane#13736) [spaceship] Fix environment variable provided sessions (fastlane#13743) Allow for the host of the Appetize API to be configured (fastlane#13765) Improves parse error reporting for non-conventional setups (fastlane#13769) Use `crash!` instead of `user_error!` on configuration access mis-use (fastlane#13766) Rip out more dead analytics code (fastlane#13741) [spaceship] support --verbose for `fastlane spaceauth` (fastlane#13752) [fastlane_core] Fix project_paths() in project.rb to respect `container:` references (fastlane#13662) [precheck] Allow mentioning Google Drive (fastlane#13754) [crashlytics] fix generated command (generate_android_command) for Windows (fastlane#13597) [docs] add id to plugin headline so it becomes linkable (fastlane#13727) [match] add new option to recreate deleted profiles in dev portal (fastlane#12539) Update puts.rb (fastlane#13739) Improve Spaceship API documentation (fastlane#13724) Update gym docs (fastlane#13725) Testfairy upload timeout (fastlane#13674) [resign.sh] only create the archived-expanded-entitlements.xcent file if the version of Xcode < 9.3 (fastlane#13685) [spaceship] remove application and version from app submission params (fastlane#13695) Improve AdbHelper (fastlane#13692) ... # Conflicts: # spaceship/lib/spaceship/two_step_or_factor_client.rb
|
Congratulations! 🎉 This was released as part of fastlane 2.109.0 🚀 |
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
This fixes a false positive in
precheck. It is reasonable that apps might integrate with Google Drive and users would want to know about this from the App Store description. Our app PDF Viewer has been approving mentioning Google Drive.Description
I added an additional entry to the whitelist for mentioning other platforms. Google is on the blacklist because it is a competitor to Apple, then Google Analytics and Google Drive are whitelisted because iOS app may integrate with these services.
I added tests for
Precheck::OtherPlatformsRule, just covering a one allowed case and one not allowed case. I don’t really know Ruby or any of the rig here so I copied and modifiedcurse_words_rule_spec.rb.