package-fastlane 2.0 that installs and builds Ruby 2.4.5 on users machine on `brew cask install fastlane` #99

joshdholtz · 2019-11-08T15:58:41Z

Motivation

Fixes fastlane/fastlane#15496

Problem

Packaged fastlane used Ruby 2.2 which is too old for some fastlane dependencies and causes installation issues leading to packaged fastlane installed version 2.28.3
Packaged fastlane could also only be built on OSX 10.1

Goal

Support Ruby 2.4.5
- A lot of Ruby dependencies are getting bumped to a Ruby 2.4 minimum due to security things
Can be built on Catalina
Easier to maintain

Description

Completely removed previous method of packaging a portal version of Ruby
- Ruby isn't really meant to do that and is tougher to do on modern macOS version and with modern Ruby versions
Ruby is now compiled on the users machine using ruby-build
- Smaller package
- Easier to update Ruby versions in the future
- Easier to test on local machine (clone repo and run ./uninstall and ./install)
Handles smooth upgrading from previous packaged version to this version
- This new version writes two text files with Ruby version and packaged fastlane version that allows for upgrades/migration
- If the package fastlane version text file isn't found, the whole ~/.fastlane/bin directory gets removed
The ./install script will only install/upgrade ruby-build and openssl only if needed
The ./install script will only build Ruby if the version declared is not already built

How To review

ALL of the logic is in uninstall and install
Everything else has pretty much been removed

How to test

Clone the repo
Run ./uninstall
Run ./install

…hine on brew cask install fastlane

taquitos · 2019-11-08T16:38:29Z

cask/fastlane.rb.template

@@ -11,3 +11,18 @@ cask 'fastlane' do



Line 5 and 6 (GitHub won't let me comment on the line) might need to be changed to point to the new install location.

@taquitos I JUST updated this file to what is actually in cask as you were commenting probably 🙃

taquitos · 2019-11-08T16:42:08Z

Do you have an idea for a good test matrix? Like what states should our mac be in when we test this update? Mojave with previous cask, without, catalina, ect... There's a decent amount of logic here I want to make sure we're covering our bases in a test matrix

joshdholtz

@taquitos Ahhh, I went over a bunch of tests with @snatchev during a pair session but probably good to create a test matrix. Maybe I'll make it in a PR template and then also drop it into this PR description. Thoughts?

taquitos · 2019-11-08T16:55:49Z

Oh, if you wrote any of that down, maybe just copypasta into a comment, otherwise maybe later on a formal matrix would be good. I really wanted to make sure we're covering all our bases but it sounds like you and @snatchev did 👍
The PR looks good to me but I'd want to make sure I can find time to test it out (which I might not have until Tuesday)

joshdholtz · 2019-11-08T16:57:25Z

@taquitos I'll def write it out! And whenever you get to it is 👍 I've been finding other people to test it out. It worked on @ohayon's machine this morning but would definitely like for you to break it too 😇

milch · 2019-11-08T19:55:05Z

install

+  # Check if old version and clean it up
+  if [ ! -f $PACKAGED_FASTLANE_VERSION_FILE ]; then
+    echoc "Found old version of brew packaged fastlane. Cleaning up..." yellow
+    "$CURRENT_DIR/uninstall" -y


Should this be calling the uninstall script of the version in ~/.fastlane/bin?

Hmmm, that is a good question actually 🤔 That isn't how it the previous one worked. The current version of packaged fastlane didn't actually copy the uninstall script that wouldn't work but I think it makes sense to put it in there. So I think I'll make changes to copy this uninstall script there after install. But for the sake of this part of the code, I'll check if there is an uninstall script in ~/.fastlane/bin and if so I'll run that otherwise I'll run the new one 😬

milch · 2019-11-08T20:00:43Z

Re: testing, how about running install/uninstall on Circle/Travis/GitHub Actions?

joshdholtz · 2019-11-08T20:17:01Z

Ahhhh yeah yeah! I'll set it up on Circle 😊 I like it I like it

ohayon

This looks great. Still pretty amazed you got this modernized and working. 💯

KrauseFx · 2019-11-11T20:41:01Z

Whoah, what is this? A reunion? 🕺 🚀 🎉

Larusso · 2019-11-14T12:08:10Z

install

+$FASTLANE_DIR/bundle/bin/bundle-env gem install fastlane --no-document --env-shebang
+
+# Copy the fastlane executable to run fastlane in the bundled environment
+cp "$CURRENT_DIR/fastlane_shim" "$FASTLANE_DIR/fastlane"


You deleted this file.
What I mean is there is no fastlane_shim in the root.

Ahhh, that was supposed to be committed! Thanks 😊

Larusso · 2019-11-14T13:30:09Z

install

 while getopts ":pub" opt; do
  case $opt in
    p ) SKIP_SETTING_PATH=1;;
-    u ) DO_UNINSTALL=1;;


The help text and the cask file still contain the -u option flag.

Oops! Thanks for catching that

Larusso · 2019-11-14T13:43:08Z

install

+{
+  PACKAGE=$1
+
+  read -p "The installer needs to install/upgrade $PACKAGE with brew. Is that okay? (y/N) " -n 1 choice


It would be very helpful to skip the prompts with a the help of a command line option. Automating the installation a little bit easier.

Larusso · 2019-11-14T15:10:57Z

So I played around a bit this afternoon because I need to roll out the newest version of fastlane to my buildmachines. As a disclaimer. I already used my own way of installing the fastlane.zip file as the defaults you set are not how I want to roll the installation process.
I used a custom cask definition which constructed a more controlled installation result for me without the need to adjust any PATH variable or that fastlane ends up in the user home directory.

version :latest
  version :latest
  sha256 :no_check

  url 'https://fastlane.tools/fastlane.zip'
  name 'fastlane'
  homepage 'https://fastlane.tools/'


  binary "#{staged_path}/fastlane_lib/snapshot"
  binary "#{staged_path}/fastlane_lib/sigh"
  binary "#{staged_path}/fastlane_lib/scan"
  binary "#{staged_path}/fastlane_lib/produce"
  binary "#{staged_path}/fastlane_lib/pem"
  binary "#{staged_path}/fastlane_lib/match"
  binary "#{staged_path}/fastlane_lib/gym"
  binary "#{staged_path}/fastlane_lib/frameit"
  binary "#{staged_path}/fastlane_lib/fastlane"
  binary "#{staged_path}/fastlane_lib/deliver"
  binary "#{staged_path}/fastlane_lib/cert"
  binary "#{staged_path}/fastlane_lib/bundle"
  binary "#{staged_path}/fastlane_lib/bundle_update_checker.rb"
  binary "#{staged_path}/fastlane_lib/parse_env.rb"
  binary "#{staged_path}/fastlane_lib/VERSION"


  preflight do
    system_command "sed", args: ['-i', '', "s/{{IS_INSTALLED_VIA_HOMEBREW}}/$INSTALLED_VIA_HOMEBREW/g", "#{staged_path}/fastlane_lib/bundle/bin/bundle-env"]
    system_command "#{staged_path}/fastlane_lib/fastlane", args: ["update_fastlane"]
  end
end

Granted this is a hard hack but worked for me so far.
To be able to roll out today I took your installer branch and adjusted a few things so it works for me again.
wooga@29b7075

I had to remove the promts, and bend the destination URL to a sub directory. This way fastlane stays in the homebew staged_path. It's not nice but get's the job done. I would love to use the default installer from you guys but without more control where stuff gets installed I can't.

Larusso · 2019-11-15T10:51:37Z

Ok I played around with it some more. I created a fork yesterday and adjusted it a little bit to be able to roll out. But I ran into OpenSSL error messages when using sigh for instance (SSL_connect returned=1 errno=0 state=error: certificate verify failed). I used rbenv and installed fastlane via gem to test the behavior there and have no issues. I updated brew and tried a fresh install again to no avail.

Larusso · 2019-11-15T13:12:47Z

Ok removing this line from bundle-env seems to fix the issue:

packaged-fastlane/bundle-env

Line 20 in 5872716

export SSL_CERT_FILE=$PREFIX/share/cacert.pem

Hey I made some adjustments to your changes for the new installer package. * Add missing `fastlane_shim` file * remove ssl certificate environment line from `bundle-env` * added option switch `-u` to skip prompts for autoupdate/install

…n-brew-install Fix 2.0 installer script

googlebot · 2019-12-04T19:42:06Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

package-fastlane 2.0 that installs and builds Ruby 2.4.5 on users mac…

062691d

…hine on brew cask install fastlane

googlebot added the cla: yes label Nov 8, 2019

joshdholtz mentioned this pull request Nov 8, 2019

Now uses Ruby 2.4 (previously 2.2) and builds on Catalina 10.15 (previously El Capitan 10.11) #98

Closed

joshdholtz requested review from ohayon, milch, snatchev and taquitos November 8, 2019 16:23

taquitos reviewed Nov 8, 2019

View reviewed changes

Josh Holtz added 2 commits November 8, 2019 10:40

Updated to published cask file and updated some README

1b5c4d5

Deployment info

5872716

joshdholtz commented Nov 8, 2019

View reviewed changes

milch approved these changes Nov 8, 2019

View reviewed changes

ohayon approved these changes Nov 11, 2019

View reviewed changes

Larusso reviewed Nov 14, 2019

View reviewed changes

Larusso and others added 2 commits November 28, 2019 16:55

Fix 2.0 installer script

fcfbc0b

Hey I made some adjustments to your changes for the new installer package. * Add missing `fastlane_shim` file * remove ssl certificate environment line from `bundle-env` * added option switch `-u` to skip prompts for autoupdate/install

Merge pull request #100 from Larusso/fix/2.0-build-and-install-ruby-o…

5772885

…n-brew-install Fix 2.0 installer script

googlebot added cla: no and removed cla: yes labels Dec 4, 2019

Added some early exits if error

4a716cf

snatchev approved these changes Dec 4, 2019

View reviewed changes

Josh Holtz added 19 commits December 4, 2019 22:44

Added some circle

1399d71

Whoops, wrong directory

6638a2d

Retrigger PR

fba382b

Forgot workflows

b1c6c30

Ruby 2.4

a261e17

Maybe this

fb8abb9

Okay, this is it

6449022

Get version and uninstall

06f9e82

a to y

2e49274

Fix some tput issues on CI

686ca40

Maybe this one

028deb1

This will be it

f885856

Or this

2ef5b11

One more time

ed0323f

Force uninstall

cd80c33

Maybe this will do it

727f20b

This is the final one

bac7dd9

Updated options for cask

593c18e

Rakefile to do the packaging

5372315

joshdholtz mentioned this pull request Dec 7, 2019

packaged-fastlane-2.0.0.zip fastlane/fastlane.tools#70

Closed

joshdholtz changed the title ~~package-fastlane 2.0 that installs and builds Ruby 2.4.5 on users machine on brew cask install fastlane~~ package-fastlane 2.0 that installs and builds Ruby 2.4.5 on users machine on brew cask install fastlane Dec 7, 2019

joshdholtz mentioned this pull request Dec 9, 2019

brew formula using ruby@2.5 dependency #101

Merged

joshdholtz closed this in #101 Dec 10, 2019

janpio deleted the 2.0-build-and-install-ruby-on-brew-install branch December 11, 2019 19:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

package-fastlane 2.0 that installs and builds Ruby 2.4.5 on users machine on `brew cask install fastlane` #99

package-fastlane 2.0 that installs and builds Ruby 2.4.5 on users machine on `brew cask install fastlane` #99

joshdholtz commented Nov 8, 2019 •

edited

Loading

taquitos Nov 8, 2019

joshdholtz Nov 8, 2019

taquitos commented Nov 8, 2019

joshdholtz left a comment

taquitos commented Nov 8, 2019

joshdholtz commented Nov 8, 2019

milch Nov 8, 2019

joshdholtz Nov 8, 2019

milch commented Nov 8, 2019

joshdholtz commented Nov 8, 2019

ohayon left a comment

KrauseFx commented Nov 11, 2019

Larusso Nov 14, 2019 •

edited

Loading

joshdholtz Nov 14, 2019

Larusso Nov 14, 2019

joshdholtz Nov 14, 2019

Larusso Nov 14, 2019

Larusso commented Nov 14, 2019

Larusso commented Nov 15, 2019

Larusso commented Nov 15, 2019

googlebot commented Dec 4, 2019

package-fastlane 2.0 that installs and builds Ruby 2.4.5 on users machine on brew cask install fastlane #99

package-fastlane 2.0 that installs and builds Ruby 2.4.5 on users machine on brew cask install fastlane #99

Conversation

joshdholtz commented Nov 8, 2019 • edited Loading

Motivation

Problem

Goal

Description

How To review

How to test

Choose a reason for hiding this comment

Choose a reason for hiding this comment

taquitos commented Nov 8, 2019

joshdholtz left a comment

Choose a reason for hiding this comment

taquitos commented Nov 8, 2019

joshdholtz commented Nov 8, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

milch commented Nov 8, 2019

joshdholtz commented Nov 8, 2019

ohayon left a comment

Choose a reason for hiding this comment

KrauseFx commented Nov 11, 2019

Larusso Nov 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Larusso commented Nov 14, 2019

Larusso commented Nov 15, 2019

Larusso commented Nov 15, 2019

googlebot commented Dec 4, 2019

package-fastlane 2.0 that installs and builds Ruby 2.4.5 on users machine on `brew cask install fastlane` #99

package-fastlane 2.0 that installs and builds Ruby 2.4.5 on users machine on `brew cask install fastlane` #99

joshdholtz commented Nov 8, 2019 •

edited

Loading

Larusso Nov 14, 2019 •

edited

Loading