-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When installing via homebrew it downloads version 2.28.3 instead of the latest version #15496
When installing via homebrew it downloads version 2.28.3 instead of the latest version #15496
Comments
Thanks for this. I couldn't figure out why my fresh install of fastlane was failing with the error: [!] undefined method `each' for nil:NilClass But installing from ruby gems instead of brew made it work 👍 |
cc @joshdholtz |
I think it is because one of the dependencies fails to update:
The brew package seems to be still using ruby 2.2? |
@joshdholtz @janpio Any update on this issue? |
Looking into! Will update when I have more info |
@joshdholtz Here's what I'm getting on my up-to-date Mojave machine. |
Here is what I am using as a temporary workaround while this Homebrew installation issue is being considered. Note: I could not install via gems b/c of the organization of Xcode 11 w/ Mojave. In order to correct that setup and get on Fastlane 2.134.0. If you are using a later version of MacOS, consider updating the command line tools executable package command. Trash existing homebrew installation
Reinstall header files on Mac
Now update Ruby to v2.6.5 as Ruby v2.3 (default on Mojave) will not work with Fastlane
|
Due to enormous amount of people used to install all the things via homebrew maybe we should just prune all fastlane versions <= 2.28 from it? |
@Katsz How do you want to do that. It's an unversioned cask. It downloads a zip file from this unversioned URL |
Heyyyy 👋 I'm currently working on a PR for this! Problem
Solution
We are still undergoing some testing but my goal is to get it released next week 🤞 If anybody is willing to help test this please let me know! |
@Larusso my bad, wasn't aware fastlane is |
@joshdholtz I tried it out and it failed for me. With the changes you propose you should also think about moving the whole thing into a brew formular. Because installing ruby etc during installation time is not really what brew cask is for. |
@Larusso I'll look into! I'm not a fan of my changes I made with install Ruby but it "works" 😬 I'll look into this 😊 |
@joshdholtz Will your changes work on macOS Mojave? I am still running on Mojave to avoid issues (If there is any) running with React-native. |
Yup yup! It will 😊 I have both a Catalina and Mojave machine that I’m testing this on |
Any updates on this? I'm needing to get 2.136 or greater because of #14573 |
Our product uses fastlane and depends on installing fastlane via https://fastlane.tools/fastlane.zip. Will that distribution mechanism be updated so that it can be updated to latest fastlane instead of being stuck on 2.28.3? Just an FYI that this isn't limited to homebrew. |
Thanks for this context @chrisvire, @joshdholtz is working on fixing this. |
For anyone not able to wait for the official fix. I added some fixes/customization to the pull request from @joshdholtz. Some of the changes are tailored for my needs and preferences. In short:
I adjusted my custom cask file which can be found here: I'm running with this fix the last couple of days and everything works so far for me. |
@Larusso That is great! Do you mind making a PR into my PR for that? That would be so 💯 |
@joshdholtz I'll take it without my custom modifications with the install path? |
@joshdholtz Yeah yeah, sorry! I should have mentioned that. Not enough coffee yet 🙃 I appreciate all your testing on this and want to make sure that you get credit for your changes/time as well. I got sidetracked with some other fixes that needed to get made but this is now number 1 priority |
Hey, everyone! This is all fixed now 😊 So...
This is ready to go as of this morning 😊 There will be official announcements, docs, and migration notes coming out later 💪 Sorry about this taking so long 😇 It was quite an adventure. Ping me if anybody has any questions! |
@joshdholtz Does this also fix installing using https://fastlane.tools/fastlane.zip? Our software uses fastlane and downloads from that url. |
@chrisvire That zip file is actually going to be removed here soon 😇 That was the cause of all the problem because it was being bundled with an old version of Ruby and the way that that was designed does not work well with newer versions of Ruby. I'm not exactly sure how your systems work but I would recommend using |
We can’t require a dependency on homebrew. We need the zip distribution that includes ruby. |
@joshdholtz Running |
Cask version installs pretty old version (2.28.3) and according to this issue: fastlane/fastlane#15496 theres also `brew install fastlane` which installs latest version.
According to [this note](fastlane/fastlane#15496 (comment)) by @joshdholtz, the old method of using `brew cask install fastlane` doesn't work anymore, as it installs an old version. The currently supported way is `brew install fastlane` (sans `cask`), which is not reflected in the docs just yet.
Updating doc as per fastlane/fastlane#15496 (comment)
* Update cd.md Updating doc as per fastlane/fastlane#15496 (comment) * Update src/docs/deployment/cd.md Co-Authored-By: Jon Tippens <legalcodes@users.noreply.github.com> Co-authored-by: Jon Tippens <legalcodes@users.noreply.github.com>
New Issue Checklist
Issue Description
When installing fastlane via homebrew using
brew cask install fastlane
it always downloads version2.28.3
Installing via ruby gems using the command
sudo gem install fastlane -NV
it correctly installs the latest version.Command executed
My OS is Mac OS Catalina
✅ fastlane environment ✅
Stack
System Locale
fastlane files:
No Fastfile found
No Appfile found
fastlane gems
Loaded fastlane plugins:
No plugins Loaded
Loaded gems
generated on: 2019-10-10
The text was updated successfully, but these errors were encountered: