Now uses Ruby 2.4 (previously 2.2) and builds on Catalina 10.15 (previously El Capitan 10.11) #98
Conversation
joshdholtz
changed the title
|
Turns out this currently has some harcoded absolute paths to |
|
Wow! |
| @@ -145,32 +145,9 @@ module FastlaneRake | |||
| @@installed_openssl = openssl_tasks.installed_path | |||
| def self.openssl_task | |||
| @@installed_openssl | |||
| raise "ugh - #{@@installed_openssl}" | |||
| @@ -210,7 +187,7 @@ module FastlaneRake | |||
| # ------------------------------------------------------------------------------ | |||
| @@installed_bundler_bin = File.join(BUNDLE_DESTROOT, 'bin/bundle') | |||
| file @@installed_bundler_bin => rubygems_update_dir do | |||
| install_gem 'bundler' | |||
| install_gem 'bundler', '1.13.6' | |||
There was a problem hiding this comment.
Okay to lock on this specific version? Maybe '~> 1.13' is fine?
| @@ -14,7 +13,7 @@ WORKBENCH_DIR = FastlaneRake::WORKBENCH_DIR | |||
| DOWNLOAD_DIR = FastlaneRake::DOWNLOAD_DIR | |||
| DESTROOT = FastlaneRake::DESTROOT | |||
| FASTLANE_GEM_VERSION = FastlaneRake::FASTLANE_GEM_VERSION | |||
| XCODE_PATH = '/Applications/Xcode-7.3.1.app' | |||
| RUBY__VERSION = FastlaneRake::RUBY__VERSION | |||
There was a problem hiding this comment.
The double-underscore looks like a mistake. Intentional on FastlaneRake ? Also, doesn't extending bring in the constants already?
There was a problem hiding this comment.
Edit, I see the need for the double-under (RUBY_VERSION is already defined). Lets call it something else. INSTALL_VERSION or something.
| @@ -108,7 +108,7 @@ module FastlaneRake | |||
| READLINE_VERSION = '6.3' | |||
| READLINE_URL = "http://ftpmirror.gnu.org/readline/readline-#{READLINE_VERSION}.tar.gz" | |||
|
|
|||
| RUBY__VERSION = '2.2.4' | |||
| RUBY__VERSION = '2.4.5' | |||
| RUBY_URL = "http://cache.ruby-lang.org/pub/ruby/2.2/ruby-#{RUBY__VERSION}.tar.gz" | |||
There was a problem hiding this comment.
Ah, I see need for the double-under.
http://cache.ruby-lang.org/pub/ruby/2.2/ruby-2.4.5.tar.gz returns a 404. RUBY_URL looks unused.
| require 'json' | ||
|
|
||
| load './bundle_tasks.rake' | ||
| extend FastlaneRake | ||
|
|
||
| BUNDLE_VERSION = 1.8 | ||
| BUNDLE_VERSION = 1.9 |
There was a problem hiding this comment.
Feels like this is major version bump worthy?
| task :build_ruby do | ||
| full_path = File.join(DESTROOT, 'bundle') | ||
|
|
||
| command = "/usr/local/bin/ruby-build #{RUBY__VERSION} #{full_path}" |
There was a problem hiding this comment.
Doe we require that ruby-build is already installed?
| command = "/usr/local/bin/ruby-build #{RUBY__VERSION} #{full_path}" | ||
| puts "Install Command: #{command}" | ||
|
|
||
| success = system({'RUBY_CONFIGURE_OPTS' => '--with-openssl-dir=/usr/local/opt/openssl'}, command) |
There was a problem hiding this comment.
Worth getting the error output here to show on failure?
| @@ -108,7 +108,7 @@ module FastlaneRake | |||
| READLINE_VERSION = '6.3' | |||
| READLINE_URL = "http://ftpmirror.gnu.org/readline/readline-#{READLINE_VERSION}.tar.gz" | |||
|
|
|||
| RUBY__VERSION = '2.2.4' | |||
| RUBY__VERSION = '2.4.5' | |||
There was a problem hiding this comment.
Any reason not to use an even later version?
|
Closing this in favor of #99 |
Fixes fastlane/fastlane#15496
Motivation
Problem
2.28.3Goal
Description
aws-sdk-v1which had a dependency ofnokogirias this was only used for the Fabric appRubyTaskto manually build Ruby 2.2Results