🌭 Update ABI definitions and stub out some hostcalls #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds several new hostcalls and type definitions to the ABI. The level of implementation varies: - `fastly_http_body::abandon` is fully implemented. - `fastly_http_req::send_v2` and friends will work, but do not yet populate the new `$error_detail` field with information about the failure. - `fastly_http_req` hostcalls `downstream_client_oh_fingerprint`, `redirect_to_websocket_proxy_v2`, `redirect_to_grip_proxy_v2`, and `fastly_key_is_valid` are stubs that return `Error::NotAvailable`. Beyond these added functions, there are a number of formatting fixes in the witx to make the Viceroy copy of these files more precisely match what we use internally to define the platform.
acfoltzer
added
the
feature-prod
acfoltzer
requested review from
a team and
awortman-fastly
and removed request for
a team
acw
approved these changes
Sep 12, 2023
cmckendry
pushed a commit
to 1stdibs/Viceroy
that referenced
this pull request
Feb 8, 2024
Adds several new hostcalls and type definitions to the ABI. The level of implementation varies: - `fastly_http_body::abandon` is fully implemented. - `fastly_http_req::send_v2` and friends will work, but do not yet populate the new `$error_detail` field with information about the failure. - `fastly_http_req` hostcalls `downstream_client_oh_fingerprint`, `redirect_to_websocket_proxy_v2`, `redirect_to_grip_proxy_v2`, and `fastly_key_is_valid` are stubs that return `Error::NotAvailable`. Beyond these added functions, there are a number of formatting fixes in the witx to make the Viceroy copy of these files more precisely match what we use internally to define the platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds several new hostcalls and type definitions to the ABI. The level of implementation varies:
fastly_http_body::abandonis fully implemented.fastly_http_req::send_v2and friends will work, but do not yet populate the new$error_detailfield with information about the failure.fastly_http_reqhostcallsdownstream_client_oh_fingerprint,redirect_to_websocket_proxy_v2,redirect_to_grip_proxy_v2, andfastly_key_is_validare stubs that returnError::NotAvailable.Beyond these added functions, there are a number of formatting fixes in the witx to make the Viceroy copy of these files more precisely match what we use internally to define the platform.