🚚 Support for trailers and trailer modification #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acfoltzer
suggested changes
Oct 23, 2023
Co-authored-by: Adam C. Foltzer <acfoltzer@acfoltzer.net>
acfoltzer
approved these changes
Oct 23, 2023
cmckendry
pushed a commit
to 1stdibs/Viceroy
that referenced
this pull request
Feb 8, 2024
This PR adds support for trailers. Trailers can be extremely useful for gRPC connections, and this PR allows trailers from a backend connection to flow back through the system. This usage is validated in tests, and has been independently validated by examples on my laptop. In addition, it provides experimental support for viewing, modifying, and/or adding trailers through a new set of ABI functions. --------- Co-authored-by: Mike Zeller <mzeller@fastly.com> Co-authored-by: Adam C. Foltzer <acfoltzer@acfoltzer.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds support for trailers and trailer modification through Viceroy, all of which should be considered experimental for the time being, as we explore the right interfaces for this work.
I've validated this version against grpcurl and an open grpc interface.