DEVLIB-1257: Rename Compute@Edge to Compute #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doramatadora
requested review from
a team,
kailan,
ulyssa and
kpfleming
and removed request for
a team and
kailan
kpfleming
previously approved these changes
Oct 26, 2023
ulyssa
reviewed
Oct 26, 2023
doramatadora
commented
Oct 27, 2023
kpfleming
approved these changes
Oct 27, 2023
| @@ -1,6 +1,6 @@ | |||
| # 🔗 compute-at-edge-abi | |||
There was a problem hiding this comment.
@doramatadora and @kpfleming - do we want to rename this and the folder?
There was a problem hiding this comment.
Oh... good question. That's going to be a breaking change for anything which consumes the content here?
There was a problem hiding this comment.
Maybe not.. it appears that the WITX files are incorporated into the crate but the directory name is not part of the crate.
There was a problem hiding this comment.
But one of the WITX files is named compute-at-edge.witx.
cmckendry
pushed a commit
to 1stdibs/Viceroy
that referenced
this pull request
Feb 8, 2024
* DEVLIB-1257: Rename Compute@Edge to Compute * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: DEVLIB-1257
Please review and notify DevRel (and @Integralist) of the new Viceroy release 🙌🏼