Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚢 update viceroy package name and README #41

Merged
merged 5 commits into from
Jul 15, 2021
Merged

Conversation

aturon
Copy link
Contributor

@aturon aturon commented Jul 15, 2021

This PR addresses a couple remaining issues for release and publication to crates.io: updating the cli package name to viceroy, and updating the README to reflect the current state of play.

Fixes #31.

@cratelyn cratelyn self-requested a review July 15, 2021 18:59
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah! I have one (1) typo to fix, and then a small quibble about the "Installation" section.

Otherwise, this looks like it's ready to go!

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
aturon and others added 2 commits July 15, 2021 13:05
Co-authored-by: katelyn martin <kmartin@fastly.com>
@aturon
Copy link
Contributor Author

aturon commented Jul 15, 2021

I've pushed another commit, refining the text to push people more toward the Fastly CLI, and to be more clear that the CLI descriptions in the README are about Viceroy's standalone interface.

Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Now, off to the registry 😍 📦 📑

@aturon aturon merged commit 6615217 into main Jul 15, 2021
@aturon aturon deleted the ajt/more-release-prep branch July 15, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README mentions --manifest-path but that flag doesn't appear in the help output
2 participants