Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Syslog logging endpoint support #55

Merged
merged 8 commits into from
May 8, 2020
Merged

Adds Syslog logging endpoint support #55

merged 8 commits into from
May 8, 2020

Conversation

mccurdyc
Copy link
Collaborator

@mccurdyc mccurdyc commented May 6, 2020 •
edited
Loading

Relevant (Referenced) Link(s)

Validation

$ make test

git clone git@github.com:mccurdyc/cli.git /tmp/cli && \
( 
    cd /tmp/cli && \
    git checkout mccurdyc/logging-syslog && \
    make test && \
    rm -rf /tmp/cli \
)

@mccurdyc
Add Syslog endpoint support
01731d4 
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
@mccurdyc mccurdyc requested a review from phamann May 6, 2020 15:56
phamann
phamann requested changes May 6, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @mccurdyc a few minor typos and one question around how we handle fastly.Cbool().

pkg/logging/syslog/create.go Outdated Show resolved Hide resolved
pkg/logging/syslog/create.go Show resolved Hide resolved
pkg/logging/syslog/update.go Outdated Show resolved Hide resolved
pkg/logging/syslog/describe.go Outdated Show resolved Hide resolved
pkg/logging/syslog/list.go Outdated Show resolved Hide resolved
@mccurdyc @phamann
Apply suggestions from code review
3c25124 
s/Amazon Syslog/Syslog/g

Co-authored-by: Patrick Hamann <patrick@fastly.com>
@mccurdyc mccurdyc mentioned this pull request May 7, 2020
Merged
phamann
phamann approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

phamann
phamann reviewed May 8, 2020
View reviewed changes
pkg/logging/syslog/root.go Outdated Show resolved Hide resolved
@phamann phamann added the enhancement New feature or request label May 8, 2020
mccurdyc and others added 5 commits May 8, 2020 08:32
@mccurdyc
Merge branch 'master' of github.com:fastly/cli into mccurdyc/logging-…
a72c2de 
…syslog
@mccurdyc @phamann
Apply suggestions from code review
f0448e7 
Fix grammar error and inconsistency.

Co-authored-by: Patrick Hamann <patrick@fastly.com>
@mccurdyc
fix tests
205b9ec 
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
@mccurdyc
Merge branch 'mccurdyc/logging-syslog' of github.com:mccurdyc/cli int…
f27c251 
…o mccurdyc/logging-syslog
@mccurdyc
fix tests
f8a2807 
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
@mccurdyc mccurdyc merged commit 817b5bd into fastly:master May 8, 2020
@mccurdyc mccurdyc deleted the mccurdyc/logging-syslog branch May 8, 2020 13:10
@mccurdyc mccurdyc changed the title logging: adds syslog logging endpoint Adds Syslog logging endpoint support May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccurdyc @phamann