Fix s3 #26
Merged
Fix s3 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the s3_logging method documentation
|
@ctdk looks good. Merging. |
set5think
pushed a commit
that referenced
this pull request
Apr 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding s3 logging, updated to work against the branch that was just merged and double checked to see if it worked.
I was not quite sure about the best place to add tests for this (new file, stuff it into common.rb, etc.), but this is what I used to test it:
fastly.create_s3_logging(:service_id => service.id, :version => latest_version.number, :name => "tests3", :access_key => "moohoo", :secret_key => "fakeyfake", :path => "/morm/", :period => 3600, :bucket_name => "glormic")
fastly.get_s3_logging(service.id, latest_version.number, "tests3")
fastly.list_s3_loggings(:service_id => service.id, :version => latest_version.number)
... where service and latest_version are defined the usual way.