Add format_version to S3Logging and Syslog resources
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seth Chisamore <schisamo@chef.io>
|
The Travis failure is on Ruby 1.9.3 only and appears to be related to a RuboCop incompatibility with Ruby 1.9.3. |
|
Thanks @schisamo |
chef-delivery
pushed a commit
to sous-chefs/fastly
that referenced
this pull request
Sep 6, 2016
This change allows us to creating S3 logging endpoints that fully support v2 of Fastly's custom log format: https://docs.fastly.com/guides/streaming-logs/custom-log-formats Please note this change should not be merged until the following feature ships in the Fastly Ruby gem: fastly/fastly-ruby#96 Signed-off-by: Seth Chisamore <schisamo@chef.io>
|
@lanej is it possible to get a gem released with this code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Seth Chisamore schisamo@chef.io