Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cannot clear certain cache keys #32

Closed
kf6nux opened this issue Feb 8, 2017 · 1 comment
Closed

[BUG] Cannot clear certain cache keys #32

kf6nux opened this issue Feb 8, 2017 · 1 comment

Comments

@kf6nux
Copy link
Contributor

kf6nux commented Feb 8, 2017

This line alters keys that begin with a slash or contain more than one slash in a row.

E.g.1: A call to
/service/yourservice/purge//keyStartingWithASlash
becomes
/service/yourservice/purge/keyStartingWithASlash

E.g.2: A call to
/service/yourservice/purge/keyWithDouble//Slash
becomes
/service/yourservice/purge/keyWithDouble/Slash

It appears the intended behavior at this line is something more along the lines of "add or remove slashes as needed at the joined location when merging the host path with the api path" or in code: 57dedaf

Tangentially related:
Due to #14, it's worth noting that Fastly explicitly states that keys should not be URL encoded. If/when a fix for #14 does URL encode data parameters to the Fastly API, that fix must not URL encode cache keys.

kf6nux pushed a commit to kf6nux/go-fastly that referenced this issue Feb 8, 2017
kf6nux pushed a commit to kf6nux/go-fastly that referenced this issue Feb 9, 2017
sethvargo added a commit that referenced this issue Feb 9, 2017
@kf6nux
Copy link
Contributor Author

kf6nux commented Feb 9, 2017

Thanks for the merge @sethvargo ! I'll close this issue out.

@kf6nux kf6nux closed this as completed Feb 9, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant