core: use rtimer instead of qtimer for everything #48027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-fastly
reviewed
Jun 26, 2024
sima-fastly
reviewed
Jun 26, 2024
sima-fastly
reviewed
Jun 26, 2024
sima-fastly
reviewed
Jun 26, 2024
jkarneges
force-pushed
the
jkarneges/core-rtimer
branch
from
c967bd4
to
5a81055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The max number of allowed RTimers is configured at start time, so this number needs to be adjusted in proxy & handler to cover any new usages. Currently, RTimer usage is per-session, with a limit of 10 per session (an overestimate). This PR adds an extra 100 miscellaneous timers to cover per-thread timers such as the ones in StatsManager, the default ZhttpManager, and various QZmqSockets.
For the proxy, it also adds 10 per "zroute" (a route with a zhttp target), since each zroute contains a ZhttpManager which contains timers. This required introducing a zroutes maximum. Routes with zhttp targets are likely not used much by anyone, and having a lot of them would be even more unusual, so the max is hardcoded rather than configurable.