Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why does approver exist instead of return? #2

Closed
rjbs opened this issue May 18, 2020 · 1 comment
Closed

why does approver exist instead of return? #2

rjbs opened this issue May 18, 2020 · 1 comment

Comments

@rjbs
Copy link
Member

rjbs commented May 18, 2020

if ($self->interactive) {
# exits on lack of user confirmation
my $approver = App::MintTag::Approver->new($self->config);
$approver->confirm_plan;
}

Seems strange to me to let the approver exit, instead of just letting it signal approval. Then the caller can do the right thing. Minor, but we're usually well served to keep things like "exit" near the top level if we can.

@mmcclimon
Copy link
Contributor

heh oops, mistyped an issue number in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants