Multi Auth #1612
Merged
Multi Auth #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove the GhUserDetails struct rename login to username
create fastn_user on github oauth callback
fix: user_details processors handle empty cookie string that occurs right after logout event fix: remove password field from create_user response
amitu
reviewed
Dec 18, 2023
amitu
reviewed
Dec 18, 2023
amitu
reviewed
Dec 18, 2023
amitu
reviewed
Dec 18, 2023
amitu
reviewed
Dec 18, 2023
amitu
requested changes
Dec 18, 2023
send SMTP emails in fastn
|
Thanks @amitu for the review. I'll fix the issues raised, add tests and, integrate diesel orm as you suggested. |
amitu
reviewed
Dec 18, 2023
amitu
reviewed
Dec 18, 2023
amitu
reviewed
Dec 18, 2023
amitu
reviewed
Dec 18, 2023
amitu
reviewed
Dec 18, 2023
|
@siddhantk232 also checkout https://github.com/orgs/fastn-stack/discussions/1449, and start thinking of ways we can make progress there. |
and mailer instantiation errror
amitu
reviewed
Dec 26, 2023
amitu
reviewed
Dec 26, 2023
amitu
reviewed
Dec 27, 2023
amitu
previously approved these changes
Dec 27, 2023
siddhantk232
force-pushed
the
feat/multiauth
branch
from
c6325a6
to
aaf25ad
Compare
|
a demo created using changes introduced in this PR: https://github.com/siddhantk232/fastn-test-multiauth @amitu I think we can merge this PR now. Remaining things will be done in a new PR |
Signed-off-by: Amit Upadhyay <upadhyay@gmail.com>
amitu
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds emailpassword login (sign in using email and password) on top of the current github oauth. Both github oauth and emailpassword strategy create a
fastn_user(database table). Seemultiauth.sqlfor more details on the required tables for authentication.It'll be possible in future to merge two accounts by logging in to two
accounts.
step will not be considered when logged in using github
user-detailsprocessors. The
user-detailsprocessor requires no change in existingcodebases. Expect bugs in other places.
TODO
Refactor code that makes database queries in.emailpassword.rs. Themod dbuses code copied from thesqlprocessor. Ideally they should share the db pool. This will be fixed in a new PR