Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove manifest.json reads from fs fetch #1760

Merged
merged 2 commits into from
Feb 13, 2024
Merged

fix: remove manifest.json reads from fs fetch #1760

merged 2 commits into from
Feb 13, 2024

Conversation

harshdoesdev
Copy link
Contributor

Removing manifest.json reads for dependency packages when resolving static file requests is the first step. The next step would be to update the logic for ftd.image-src so that if a particular variant of an image does not exist, it should not attempt to fetch it.

@amitu
Copy link
Contributor

amitu commented Feb 13, 2024

@harshdoesdev is this ready?

@harshdoesdev
Copy link
Contributor Author

@harshdoesdev is this ready?

Yes, this can be merged.

@amitu amitu merged commit 6b11a58 into main Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants