ROAD-539 / Fix debounce of inputs' preview #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
commented
Sep 5, 2023
| end | ||
|
|
||
| expect(page).to have_text("Edit Story") | ||
| it "debounces the requests to update the preview to not flood the server" do |
There was a problem hiding this comment.
above this line it's the same code as before, I just moved those 2 specs in a preview context, the important change is this last new test
torresga
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
https://ombulabs.atlassian.net/browse/ROAD-539
Motivation / Context
This PR fixes #250
We have code to debounce the preview, but the code was not really doing a debounce, it was just delaying the requests but still doing all of them (and even doing extra requests since it was triggering the preview of the 2 inputs for any input change (even the title changing)).
This PR moves some things around to keep the debounceTimer in the right scope and to only update the preview of the text area that changed.
QA / Testing Instructions
/stories/render_markdown) a moment after we stop typing instead of a request for each keystrokeI will abide by the code of conduct.