Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update magnetic forward functions for dipoles #450

Closed
santisoler opened this issue Jan 10, 2024 · 0 comments · Fixed by #453
Closed

Update magnetic forward functions for dipoles #450

santisoler opened this issue Jan 10, 2024 · 0 comments · Fixed by #453
Labels
enhancement Idea or request for a new feature
Milestone
v0.7.0

Comments

@santisoler
Copy link
Member

Description of the desired feature:

After solving #446 and #447 with #448, we should apply similar changes to the dipole magnetic forward functions.

In a nutshell:

  • merge the dipole_magnetic and dipole_magnetic_component functions into a single one,
  • change the shape and type of the expected magnetic_moment argument: it should be a tuple of three arrays: mag_moment_e, mag_moment_n, mag_moment_u.

Are you willing to help implement and maintain this feature?

Sure!
@santisoler santisoler added the enhancement Idea or request for a new feature label Jan 10, 2024
@santisoler santisoler added this to the v0.7.0 milestone Jan 26, 2024
@santisoler santisoler mentioned this issue Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Idea or request for a new feature
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Merge magnetic forward functions for dipoles fatiando/harmonica
1 participant
@santisoler