Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataVerse file DOIs in pooch.retrieve #356

Open
dokempf opened this issue Mar 14, 2023 · 1 comment
Open

DataVerse file DOIs in pooch.retrieve #356

dokempf opened this issue Mar 14, 2023 · 1 comment
Labels
enhancement Idea or request for a new feature

Comments

@dokempf
Copy link
Contributor

dokempf commented Mar 14, 2023

Description of the desired feature:

In #354 we learned that DataVerse distinguishes dataset PIDs and file PIDs. Given that information, it could be discussed whether the following code should be supported:

filename = pooch.retrieve("doi:<dataverse-file-doi>")

I think it would be perfectly valid to discard this as out of scope - I just wanted to put out the question. The reasoning for out of scope would be: DOI resolution in pooch assumes a one-to-one correspondence of a pooch.Pooch instance and a data set. DOI resolution outside of this context is not supported. If on the other hand DOI resolution is extended to retrieve, this might happen for other data repositories as well, so it needs to be done proper.

Are you willing to help implement and maintain this feature?

Yes, with no specific timeline for the implementation.

@dokempf dokempf added the enhancement Idea or request for a new feature label Mar 14, 2023
@leouieda
Copy link
Member

@dokempf I've been thinking about this and it would generate a bit of a disconnect between pooch.Pooch and pooch.retrieve since it wouldn't make sense to create a Pooch class for a repository with a single file. But if the individual file has a DOI and we keep the syntax of URLs having file names at the end, then I'd be fine with this use case. I guess it would mean putting in some checks in the Dataverse downloader, right? Is the API response for file and dataset different?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Idea or request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants