fix the *Tag.String method and add other useful methods #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ida5b6810f6788d8ae66daddb73f0cf4eb00af02f
Change-Id: Iaf246838a4bce668d88b9063bb2a71b85da55653
Change-Id: I4c3e8922e09d76f1ec171ee8841e3c961c1cc6d9
Change-Id: I3b15cbaf175debe0145aaf42bd5980ac146e5b2f
Change-Id: I44c9f5542104cf53ddf4584547fb798964159d13
|
Hi @henrylee2cn Thanks for your PR. Can you please update the description on what you're trying to fix or improve? I see that you also added couple of new features, which I think shouldn't be part of this PR if you intend to do something else. |
andeya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Tag.Stringto solve double quotes escaping problem.gitignorefile*Tag.AddOptionsmethod*Tag. DeleteOptionsmethod