-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working in project that uses build tags #1464
Comments
Yeah, For the most part adding this should be simple; although some tools may not (fully) support it. For example |
#1562 added support of |
@Carpetsmoker do you know of any other tools that vim-go uses that we need to add this support to, or should we close this issue since #1562 took care of the |
If this issue is closed it would be nice to see other followup issues be filed for other features that break. I listed a few (goto, autocomplete, etc). |
Fixes #1464 Depends on: davidrjenni/reftools#14 dominikh/go-tools#272 TODO: Add tests
Fixes #1464 This also removes the `:GoBuildTags` command. The documentation for `g:go_build_tags` mentions that "This is a permanent setting. A more useful way is to use |:GoBuildTags| to dynamically change or remove build tags", but all `:GoBuildTags` does is change the `go_build_tags` setting, so I guess that's an artefact from a previous implementation? We could keep it if people prefer using this, but it seems redundant to me. Depends on: davidrjenni/reftools#14 dominikh/go-tools#272 TODO: Add tests to ensure no silly mistakes were made.
Fixes #1464 Also fixes `:GoBuildTags ""` to clear the tags. Looks like this didn't work anymore (probably regression from Billy's config PR? Didn't investigate too deeply).
Fixes #1464 Also fixes `:GoBuildTags ""` to clear the tags. Looks like this didn't work anymore (probably regression from Billy's config PR? Didn't investigate too deeply).
Fixes #1464 Also fixes `:GoBuildTags ""` to clear the tags. Looks like this didn't work anymore (probably regression from Billy's config PR? Didn't investigate too deeply).
* Add build tags to many commands Fixes #1464 Also fixes `:GoBuildTags ""` to clear the tags. Looks like this didn't work anymore (probably regression from Billy's config PR? Didn't investigate too deeply). * Clarify g:go_build_tags docs * fix typo * Fix shell escaping for non-async code path * Update ChangeLog
Behavior
When working in files that have build tags, not much works. There is the command
:GoBuildTags
but it isn't pervasive. It would be nice if when you set that completion, go-to's, etc worked. This also applies to test files as well. If I set the build tag and run:GoTestFunc
it would be nice for those to be applied rather than having to write:GoTestFunc -tags <tag>
every time.Steps to reproduce:
foo
and a main.go:GoBuilldTag foo
Configuration
vimrc
: Don't think it will be necessary to reproThe text was updated successfully, but these errors were encountered: