Make sure builtins are always hightlighted correctly #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And (again for consistency) change `goMethod` to `goMethodCall` to be consistent with `goFunctionCall`.
svanharmelen
force-pushed
the
f-highlight-func-calls
branch
from
c221986
to
80b0ca2
Compare
fatih
reviewed
Oct 23, 2016
| @@ -302,7 +302,7 @@ if g:go_highlight_functions != 0 | |||
| syn match goPointerOperator /\*/ nextgroup=goReceiverType contained skipwhite skipnl | |||
| syn match goReceiverType /\w\+/ contained | |||
| syn match goFunction /\w\+/ contained | |||
| syn match goFunctionCall /\w\+\ze(/ | |||
| syn match goFunctionCall /\w\+\ze(/ contains=GoBuiltins,goDeclaration | |||
There was a problem hiding this comment.
Why do we include GoBuiltins? What does this change?
|
Thanks @svanharmelen 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And (again for consistency) change
goMethodtogoMethodCallto be consistent withgoFunctionCall.@fatih this is of course a much cleaner and better way to support all use cases correctly.