Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting function in and out parameters #1580

Closed
wants to merge 1 commit into from

Conversation

igrmk
Copy link
Contributor

@igrmk igrmk commented Nov 23, 2017

I personally like to make input parameters distinguishable from their types.
This pull request defines goParameterName syntax group to achieve it.

@igrmk
Copy link
Contributor Author

igrmk commented Nov 23, 2017

I need to add it highlights output named parameters as well.

@arp242
Copy link
Contributor

arp242 commented Nov 23, 2017

Thanks!

Would you mind maybe adding a "before" and "after" screenshot? It's not entirely clear to me what "in" and "out" parameters are, and figuring out "what is this supposed to do?" from a Vim regexp is kind of hard :-)

@igrmk
Copy link
Contributor Author

igrmk commented Nov 23, 2017

Sure.

Before:
before

After:
after

Please note caller, site and callee highlighting.

Thanks.

@igrmk
Copy link
Contributor Author

igrmk commented Nov 23, 2017

Actually it doesn't work for nested functions.
It is the case when parameter type is a function.
Let me close it and create a new one with fix later.

@igrmk igrmk closed this Nov 23, 2017
@igrmk igrmk mentioned this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants