Fix handling and change name of g:go_metalinter_excludes #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use gometalinter's `--disable` option instead of its `--exclude` to disable linters specified in `g:go_metalinter_excludes`; `--exclude` is to exclude files, `--disable` is for disabling linters. Rename `g:go_metalinter_excludes` to `g:go_metalinter_disabled` to more accurately reflect its purpose in its name and so that it's symmetric with `g:go_metalinter_enabled`.
|
lgtm |
|
TravisCI is currently having problems. Once they're back on their feet and this PR builds successfully, I'll merge it. |
|
restarted the build |
Codecov Report
@@ Coverage Diff @@
## master #1648 +/- ##
==========================================
- Coverage 22.04% 21.73% -0.32%
==========================================
Files 53 53
Lines 4173 4173
==========================================
- Hits 920 907 -13
- Misses 3253 3266 +13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use gometalinter's
--disableoption instead of its--excludetodisable linters specified in
g:go_metalinter_excludes;--excludeisto exclude files,
--disableis for disabling linters.Rename
g:go_metalinter_excludestog:go_metalinter_disabledto moreaccurately reflect its purpose in its name and so that it's symmetric
with
g:go_metalinter_enabled.