Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip autosave actions #2143

Merged
merged 2 commits into from
Feb 11, 2019
Merged

Skip autosave actions #2143

merged 2 commits into from
Feb 11, 2019

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Feb 11, 2019

  • fix syntax error when trying to skip running gofmt on save.
  • skip all auto actions when saving a buffer that is not readable.
  • change autosave actions to use existing configuration getters.

Fixes #632

washtubs and others added 2 commits February 10, 2019 21:43
@washtubs @bhcleek
Do not try to format unreadable buffers on save
c9b1e29
@bhcleek
do not perform autosave actions when file is not readable
77e4fd0 
* fix syntax error when trying to skip running gofmt on save.
* skip all auto actions when saving a buffer that is not readable.
* change autosave actions to use existing configuration getters.
@bhcleek bhcleek merged commit 96a2c2e into fatih:master Feb 11, 2019
@bhcleek bhcleek deleted the skip-autosave-actions branch February 11, 2019 06:05
@bhcleek bhcleek mentioned this pull request Feb 11, 2019
Closed
bhcleek added a commit that referenced this pull request Feb 11, 2019
@bhcleek
update CHANGELOG.md for #2143
c6537a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remote editing wipes out .go files with go_fmt_autosave enabled.
2 participants
@bhcleek @washtubs