adds options to suppress/customize delve logging; closes #2200 #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhcleek
reviewed
Mar 28, 2019
Sure. Do you mean that if |
|
Yes |
…ng suppressed if latter is empty string.
|
passes tests! 🎉 |
bhcleek
added a commit
that referenced
this pull request
Mar 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #2200 and introduces the following variables:
g:go_debug_log- defaults to1; set to0to suppress logging outputg:go_debug_log_output: defaults todebugger, rpc; set to a string that corresponds to the delvelog_outputoptions. Will only be used ifgo_debug_logis set to1.Documentation is also included.
This PR preserves the current behavior through its default settings so should be completely transparent to existing users.