refactor terminal handling #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use errorformat for GoRun error handling. Remove go#util#FilterValids, because there are no remaining callers. Add local variable prefix, `l:` to variables in autoload/go/term.vim. Handle stdout correctly in autoload/go/term.vim, including stripping unnecessary line endings that Neovim seems to add when the job is attached to a terminal. Use the usual functions for managing lists in autoload/go/term.vim instead of having some one-offs. Fixes fatih#1260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use errorformat for GoRun error handling.
Remove go#util#FilterValids, because there are no remaining callers.
Add local variable prefix,
l:to variables in autoload/go/term.vim.Handle stdout correctly in autoload/go/term.vim, including stripping
unnecessary line endings that Neovim seems to add when the job is
attached to a terminal.
Use the usual functions for managing lists in autoload/go/term.vim
instead of having some one-offs.
Fixes #1260