[add] toggle autocomplete option #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not autocompletion, it just sets the completion engine (omnifunc). But I understand the reasoning behind this. You want to introduce a setting so vim-go doesn't override omnifunc. I think that's a fair request because we're also letting you to disable |
|
@dohq are you interested in completing this PR, or should we take over? |
|
Sorry. |
dohq
force-pushed
the
feature/toggle-autocomplete
branch
from
53d5f24
to
a200ed8
Compare
|
I fixed travis error. |
|
Thank you @dohq 🙇 I'll merge this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Thanks for make great plugin.
This pr is add toggle vim-go autocompletin setting.
Recently, I think that many users consolidate AutoComplete into LSPs.
So while using vim-go's wonderful command,
I think that there is a user who wants to leave complement from LSP plug-in.