Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gb support #420

Closed
wants to merge 9 commits into from
Closed

gb support #420

wants to merge 9 commits into from

Conversation

fatih
Copy link
Owner

@fatih fatih commented May 12, 2015

This PR aims to bring full support for the http://getgb.io/ project.

Currently implemented commands are:

  • :GbBuild (valid arguments to gb build can be given, if not plan gb build is called)
  • :GbBuildAll invokes gb build all

It doesn't matter from which directory the file is being edited. vim-go automatically finds the $PROJECT and populating the errors based on it. You don't need to do anything.

Todos:

  • Check GB_PROJECT_DIR to retrieve the project dir
  • Implement :GbFiles
  • Implement :GbTest
  • Implement :GbImports, this should be use the existing auto fmt hook we have currently

vim-go is a plugin to develop go code within vim. I'm always trying to add features to it (and also allow), to make it productive for everyone. gb is a very new tool and needs some traction of course. That's why I'm thinking of creating a new vim-gb plugin that is totally compatible and orthogonal to vim-go. However I'm not sure about it, the current approach might be the correct one (may be).

I'm curious about any thoughts here so please just comment on this :)

@skelterjohn
Copy link

Any interest in supporting wgo as well? (github.com/skelterjohn/wgo)

You'd need to find a .gocfg/gopaths directory somewhere in the CWD's ancestor list, and add use each line of gopaths as a GOPATH entry.

@fatih
Copy link
Owner Author

fatih commented May 23, 2015

@skelterjohn of course.. Actually we can do it already with the foundation of #429. I'll tackle it after I'm finished with gb

@jszwedko
Copy link

@fatih I'm 👍 on this -- it might be nice to also document that GOPATH needs to be set to $(gb env) for the other go tools (like oracle) to work properly. I'm not sure if this is something that could be incorporated into vim-gos configuration or not.

@metral
Copy link

metral commented Jun 30, 2015

is there an ETA on this merge upstream?

@fatih
Copy link
Owner Author

fatih commented Jun 30, 2015

Good question @metral. Because I'm alone on this and it's Ramadan (holy month of Islam), I have not much time for my personal projects. If I have time I'll do in the following weeks. Usually I have 1-2 day of burst work on Vim-go every one month. At that time go over all issues, implement and improve features and finish current work. So just to add the information, ETA is 1 Month (but can be earlier too). Hope this helps.

@metral
Copy link

metral commented Jun 30, 2015

@fatih thank you for the quick response and the work that you put in to vim-go as well as your other repos, they're much appreciated.

hope you have a pleasant Ramadan and i look forward to the arrival of gb support in vim-go!

@jszwedko
Copy link

jszwedko commented Jul 1, 2015

@fatih do you think it'd be feasible to merge the current work supporting GbBuild and GbBuildAll? Or do you think some of the core parts are still in flux? I'd be happy to help with the rest.

@fatih
Copy link
Owner Author

fatih commented Jul 1, 2015

We now add the vendor folder directly. So any go tool (such as goimports, godef, oracle, vs..) should work without any problem. Let me know how this works for you. Thanks @euank for the contribution: #471 (Just pull the latest master)

@fatih
Copy link
Owner Author

fatih commented Jul 1, 2015

@jszwedko I'm not sure I want to add Gb prefixed commands to vim-go. Because it's a totally different project and it has it's own tools. However what we can do is give a proper support for other go tools so they work well with gb context.

@jszwedko
Copy link

jszwedko commented Jul 2, 2015

@fatih that makes sense, the Gb commands should be a separate plugin.

Thank you so much for your work on vim-go, it is awesome!

wingyplus added a commit to wingyplus/vim-go that referenced this pull request Aug 4, 2015
@wingyplus wingyplus mentioned this pull request Aug 4, 2015
wingyplus added a commit to wingyplus/vim-go that referenced this pull request Aug 4, 2015
@fatih
Copy link
Owner Author

fatih commented Jan 19, 2016

This need another round. The current PR needs to be rebased and tons of things have changed.

@fatih fatih closed this Jan 19, 2016
@fatih fatih deleted the gb-support branch January 19, 2016 01:16
@dallbee
Copy link

dallbee commented Jan 16, 2017

With this branch deleted, have plans stopped for supporting gb?

@fatih
Copy link
Owner Author

fatih commented Jan 16, 2017

Unfortunately yes, however there is still partial support (it detects src/ folder). But no further development will be made as I have limited time. Thanks.

@dallbee
Copy link

dallbee commented Jan 17, 2017

Totally understand! Thanks for being straightforward about it. Vim-go is still immensely useful and I can't thank you enough for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants