Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed errcheck with abspath #671

Merged
merged 1 commit into from
Jan 23, 2016
Merged

Conversation

hori-ryota
Copy link
Contributor

Errcheck output errors using relative path format but when failed to check packages using absolute path.

Now, absolute path inputed, vim-go errcheck add unnecessary prefix like

/your/gopath/your/gopath/filepath.go

Errcheck introduced abspath options so fixed by using it.

@fatih
Copy link
Owner

fatih commented Jan 3, 2016

Hi @hori-ryota Thanks for the PR! Can you please add a test case so I can test it ? I would appreciate it.

@hori-ryota
Copy link
Contributor Author

Where are tests implemented?

Errcheck will failed unbuildable package such as syntax error.

@fatih
Copy link
Owner

fatih commented Jan 4, 2016

@hori-ryota I meant a demo test file you can add so I can test what has changed ?

@fatih
Copy link
Owner

fatih commented Jan 21, 2016

@hori-ryota ping. I've asked for a demo.go file which fails, but is fixed with this PR. It's all so I can test it and reproduce your fix :) Let me know if I can do something here.

@hori-ryota
Copy link
Contributor Author

oh, solly for the delay.

Please test with following demo.go

package main

func main() {
    demo := "demo"
}

fatih added a commit that referenced this pull request Jan 23, 2016
@fatih fatih merged commit b85b550 into fatih:master Jan 23, 2016
@fatih
Copy link
Owner

fatih commented Jan 23, 2016

Thanks @hori-ryota. We fixed the issue with errcheck multiple times. I'm going to eventually remove it in the future because we have now :GoMetaLinter and maintaining it is simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants