go#package#Paths more efficient at getting GOROOT #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go#package#Paths for some reason would call go env GOROOT every single time it needed the GOROOT. In #697 the problem was that it was calling go to get the GOROOT every single time the statusline needed an update which resulted in the flashing cursor. Now it only calls it once and stores it in a script local variable.
fatih
added a commit
that referenced
this pull request
Jan 28, 2016
go#package#Paths more efficient at getting GOROOT
|
Thanks @nhooyr. Great fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go#package#Paths for some reason would call go env GOROOT every single
time it needed the GOROOT. In #697 the problem was that it was calling
go to get the GOROOT every single time the statusline needed an update
which resulted in the flashing cursor. Now it only calls it once and
stores it in a script local variable.